Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #345

Merged
merged 33 commits into from Jun 10, 2020
Merged

Upgrade dependencies #345

merged 33 commits into from Jun 10, 2020

Conversation

wenche
Copy link
Contributor

@wenche wenche commented Jun 4, 2020

Solves #343

wenche added 11 commits June 4, 2020 15:21
@wenche
Upgrade fix and feature in storybook
b019292
@wenche
Remove core-js as dependency as it doesn't seems to be used directly,…
b5ff3cb 
… but rather by other packages
@wenche
Use @storybook/source-loader instead of @storybook/addon-storysource/…
a8dba1b 
…loader because of deprecation warning
@wenche
⬆️ Upgrade styled-components from 4 to 5.1.1
a20d280
@wenche
Upgrade fix and feat. Upgrade github-markdown-css to 4.0.0
c9cabd7
@wenche
⬆️ Upgrade Prettier from 1.19.1 to 2.0.5. We already use the new defa…
d330acc 
…ults for trailingComma, arrowParens and endOfLine
@wenche
⬆️ Upgrade react-helmet from 5.x.x to 6.0.0. Missing title almost eve…
574e025 
…rywhere, but that's not caused by this upgrade
@wenche
⬆️ Upgrade gatsby-plugin-matomo from 0.7.2 to 0.8.3
7923919
@wenche
⬆️ Upgrade fix and feature
9a835c6
@wenche
⬆️ Upgrade prettier from 1.19.1 to 2.0.5
c0e1d34
@wenche
:arrow_up; Upgrade ramda from 0.26.1 to 0.27.0. No upgrade guide, so …
dbcf6a2 
…assuming it's safe even if there is no real semver
@wenche
Copy link
Contributor Author

wenche commented Jun 5, 2020

Seems like it will be a better option to use @koa/router instead of koa-router, but perhaps @mimarz could double check due to lack of migration guides fro 8.x.x -> 9.x.x 🤷

@wenche
Copy link
Contributor Author

wenche commented Jun 8, 2020

Because of a bug with toHaveStyleRule in styled-components-jest we can't upgrade styled-components and styled-components-jest in eds-core-react right now. See the reported issue.

@mimarz
Copy link
Contributor

mimarz commented Jun 9, 2020

Seems like it will be a better option to use @koa/router instead of koa-router, but perhaps @mimarz could double check due to lack of migration guides fro 8.x.x -> 9.x.x 🤷

Ramda imports also needs to be changed from import * as R from 'ramda' to import R from 'ramda' to support node v.13++. I can make a seperate PR for figma-broker after you are finished with this one? @wenche

@wenche
Copy link
Contributor Author

wenche commented Jun 9, 2020

Seems like it will be a better option to use @koa/router instead of koa-router, but perhaps @mimarz could double check due to lack of migration guides fro 8.x.x -> 9.x.x 🤷

Ramda imports also needs to be changed from import * as R from 'ramda' to import R from 'ramda' to support node v.13++. I can make a seperate PR for figma-broker after you are finished with this one? @wenche

Yes, that would be great @mimarz

@wenche wenche marked this pull request as ready for review June 10, 2020 06:47
@wenche wenche requested review from mimarz and vnys as code owners June 10, 2020 06:47
@wenche wenche changed the title [WIP]: Upgrade dependencies Upgrade dependencies Jun 10, 2020
mimarz
mimarz approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one sneaky space that snuck in during formatting in checbox stories, else it looks good 👍

vnys
vnys approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wenche wenche merged commit 5c06c7c into equinor:develop Jun 10, 2020
@wenche wenche deleted the dependency-update branch June 10, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@vnys vnys vnys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wenche @mimarz @vnys