Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript Story: Avatar #742

Merged
merged 15 commits into from
Oct 28, 2020
Merged

Typescript Story: Avatar #742

merged 15 commits into from
Oct 28, 2020

Commits on Oct 26, 2020

  1. 🚚 Renamed to tsx

    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    36af54b View commit details
    Browse the repository at this point in the history

  2. ✨ Declared image type 

    Needed for catImg in Avatar story
    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    e0a3c06 View commit details
    Browse the repository at this point in the history

  3. 🚚 Renamed Props to AvatarProps 

    ..
    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    63f82e6 View commit details
    Browse the repository at this point in the history

  4. 📝 Added AvatarProps to story

    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    8ff1868 View commit details
    Browse the repository at this point in the history

  5. 🚚 Had to move image declarations inside a custom_typings folder 

    Was not picked up by TS before
    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    9b2364b View commit details
    Browse the repository at this point in the history

  6. ♻️ Arrow function to named function

    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    a3c5897 View commit details
    Browse the repository at this point in the history

  7. 🎨 Arrow to named

    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    64307eb View commit details
    Browse the repository at this point in the history

  8. 🎨 JPG as type string

    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    1428aeb View commit details
    Browse the repository at this point in the history

  9. 🔥 Removed knobs 

    Not needed when we have controlled props
    @pomfrida
    pomfrida committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5427ba0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. 🎨 Self closing tags

    @pomfrida
    pomfrida committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    99bd93c View commit details
    Browse the repository at this point in the history

  2. 🚚 Moved custom_typings folder (for jpg module) into stories folder 

    Needed for the module to be used in Avatar.stories
    @pomfrida
    pomfrida committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    af2cfd3 View commit details
    Browse the repository at this point in the history

  3. 🚚 custom_typings moved to core-react/src because of jsconfig is there

    @pomfrida
    pomfrida committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b9395d3 View commit details
    Browse the repository at this point in the history

  4. 🚧 Still working on image module

    @pomfrida
    pomfrida committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5dd0c35 View commit details
    Browse the repository at this point in the history

  5. 🚧 Still not able to export the jpg module 

    TS reaches module only if custom.d.ts is opened
    @pomfrida
    pomfrida committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    c0bf2d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. 🎨 Removed useless img module and replaced local src with url 

    Quick fix instead of img module to fix ts error on img import
    @pomfrida
    pomfrida committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    cc788bb View commit details
    Browse the repository at this point in the history