Skip to content

Commit

Permalink
Inform user about failing wf jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
Lars Petter Øren Hauge authored and lars-petter-hauge committed Mar 18, 2019
1 parent 0033828 commit d24f965
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions python/python/ert_gui/tools/workflows/run_workflow_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

class RunWorkflowWidget(QWidget):

workflowSucceeded = pyqtSignal()
workflowSucceeded = pyqtSignal(list)
workflowFailed = pyqtSignal()
workflowKilled = pyqtSignal()

Expand Down Expand Up @@ -118,20 +118,26 @@ def runWorkflow(self):
time.sleep(2)

cancelled = self._workflow_runner.isCancelled()

if cancelled:
self.workflowKilled.emit()
else:
success = self._workflow_runner.workflowResult()

if not success:
self.workflowFailed.emit()
if success:
report = self._workflow_runner.workflowReport()
failed_jobs = [k for k, v in report.items() if not v['completed']]
self.workflowSucceeded.emit(failed_jobs)
else:
self.workflowSucceeded.emit()
self.workflowFailed.emit()

def workflowFinished(self):
def workflowFinished(self, failed_jobs):
workflow_name = self.getCurrentWorkflowName()
QMessageBox.information(self, "Workflow completed!", "The workflow '%s' completed successfully!" % workflow_name)
jobs_msg = "successfully!"
if failed_jobs:
jobs_msg = "\nThe following jobs failed: " + ", ".join([j for j in failed_jobs])

QMessageBox.information(self, "Workflow completed!", "The workflow '{}' completed {}".format(workflow_name, jobs_msg))
self._running_workflow_dialog.accept()
self._running_workflow_dialog = None

Expand All @@ -149,4 +155,4 @@ def workflowStoppedByUser(self):
QMessageBox.information(self, "Workflow killed!", "The workflow '%s' was killed successfully!" % workflow_name)
self._running_workflow_dialog.reject()
self._running_workflow_dialog = None

0 comments on commit d24f965

Please sign in to comment.