Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect transportable command validation #1502

Closed
markusdregi opened this issue Mar 12, 2021 · 0 comments · Fixed by #1469
Closed

Incorrect transportable command validation #1502

markusdregi opened this issue Mar 12, 2021 · 0 comments · Fixed by #1469

Comments

@markusdregi
Copy link
Contributor

There is currently a discrapency between the actual requirements of a transportable command and what is being validated. The Ensemble Evaluator expects the command to be a python script, while ert3 was aiming for this to be an executable. While I still believe we should aim for the later, we should still keep the code assumptions in sync. And changing the validation is a much lower threshold. Hence, I suggest that we start by changing the validation by simply removing the requirement that the scripts are executables.

Note: Remember to change the permission rights for the scripts in the examples and the chmod operations done directly in the various tests.

jondequinor added a commit that referenced this issue Mar 25, 2021
sondreso pushed a commit that referenced this issue Mar 25, 2021
sondreso pushed a commit that referenced this issue Mar 25, 2021
sondreso pushed a commit that referenced this issue Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant