Move get_machine_name to public API #7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this function is used outside of ert, it should not be hidden below ensemble_evalutor.config. port_handler.py serves as a placeholder for the code, but the function but exposed and should be used as ert.shared.get_machine.name()
berland
added
the
release-notes:maintenance
berland
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7965 +/- ##
==========================================
- Coverage 85.81% 85.80% -0.02%
==========================================
Files 378 378
Lines 23073 23079 +6
Branches 629 618 -11
==========================================
+ Hits 19801 19803 +2
+ Misses 3199 3195 -4
- Partials 73 81 +8 ☔ View full report in Codecov by Sentry. |
xjules
reviewed
May 27, 2024
|
|
||
| from ert.shared import get_machine_name as ert_shared_get_machine_name |
There was a problem hiding this comment.
Can this be only from ert.shared import get_machine_name as _get_machine_name?
There was a problem hiding this comment.
Hmm, I think i prefer the explicitness of the long name. Nonetheless, we will change this again in short time when we remove the deprecated (private) API.
xjules
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this function is used outside of ert, it should not be hidden below ensemble_evalutor.config.
port_handler.py serves as a placeholder for the code, but the function but exposed and should be used as ert.shared.get_machine.name()
Issue
Resolves #7888
Approach
🚚
When applicable