Fix_run_analysis #154
Merged
Fix_run_analysis #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakim-hove
reviewed
Oct 3, 2018
| @@ -55,7 +58,9 @@ def run(self): | |||
|
|
|||
| target_fs = fs_manager.getFileSystem(target) | |||
| source_fs = fs_manager.getFileSystem(source) | |||
| success = es_update.smootherUpdate( source_fs , target_fs ) | |||
| mask = BoolVector( initial_size = ert.getEnsembleSize(), default_value = True) | |||
There was a problem hiding this comment.
Instead of just making the all active global mask in this way - please see: equinor/libres#395 for how to use enkf_fs to create a mask; could possibly add a method on the EnkfFs class to provide such a mask.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
There is a bug in run_analysis.py due to changes to Statoil/libres code.
Approach
An es_update call uses run_context.
Pre un-WIP checklist
Depends on