-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/step type class 1571 #1591
Merged
sregales-TNO
merged 7 commits into
equinor:master
from
sregales-TNO:feature/step_type_class_1571
Apr 30, 2021
Merged
Feature/step type class 1571 #1591
sregales-TNO
merged 7 commits into
equinor:master
from
sregales-TNO:feature/step_type_class_1571
Apr 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondequinor
reviewed
Apr 28, 2021
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
from
April 28, 2021 08:13
9f267d3
to
254d4e3
Compare
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
from
April 28, 2021 08:44
254d4e3
to
28dc9d9
Compare
jondequinor
reviewed
Apr 28, 2021
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
3 times, most recently
from
April 29, 2021 09:12
b336899
to
604a5ef
Compare
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
from
April 29, 2021 09:52
604a5ef
to
0aaa31b
Compare
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
2 times, most recently
from
April 30, 2021 08:39
5c0f5b1
to
0aaa31b
Compare
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
from
April 30, 2021 09:48
cf299d8
to
0af5a72
Compare
sregales-TNO
force-pushed
the
feature/step_type_class_1571
branch
from
April 30, 2021 09:52
0af5a72
to
4cf49e7
Compare
jondequinor
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #1571
Approach
Step class was completely removed and replaced with the Union of its subparts Unix and Function classes.