Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/step type class 1571 #1591

Merged

Conversation

sregales-TNO
Copy link
Contributor

Issue
Resolves #1571

Approach
Step class was completely removed and replaced with the Union of its subparts Unix and Function classes.

@sregales-TNO sregales-TNO self-assigned this Apr 28, 2021
@sregales-TNO sregales-TNO force-pushed the feature/step_type_class_1571 branch 3 times, most recently from b336899 to 604a5ef Compare April 29, 2021 09:12
@sregales-TNO sregales-TNO enabled auto-merge (squash) April 29, 2021 12:06
@sregales-TNO sregales-TNO force-pushed the feature/step_type_class_1571 branch 2 times, most recently from 5c0f5b1 to 0aaa31b Compare April 30, 2021 08:39
Copy link
Contributor

@jondequinor jondequinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great. Thank you

@sregales-TNO sregales-TNO merged commit 960b2e1 into equinor:master Apr 30, 2021
@sregales-TNO sregales-TNO deleted the feature/step_type_class_1571 branch April 30, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make config for different step types into separate classes
2 participants