Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal model updating case #172

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Conversation

markusdregi
Copy link
Contributor

@markusdregi markusdregi commented Nov 13, 2018

Task
Created an ERT-case for doing model updates with the model being nothing but a second degree polynomial.

See the README for a more thorough introduction.

Pre un-WIP checklist

  • Statoil tests pass locally
  • Have completed graphical integration test steps

@markusdregi markusdregi changed the title WIP: Poly case Minimal model updating case Nov 14, 2018
@ghost ghost removed in progress labels Nov 14, 2018
@markusdregi markusdregi reopened this Nov 14, 2018
@ghost ghost added in progress labels Nov 14, 2018
Copy link
Contributor

@andreabrambilla andreabrambilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, we really need an example like this for the EnKF! 👏 👍
Shall we actually have a test that runs this and checks that the value of the parameters at the end?

And we should definitely have a time dependent version, which would be more similar to the real cases EnKF is used for

@markusdregi
Copy link
Contributor Author

I agree that we should have a test for this. I though that this could be the very first application of #165 when that has been merged.

And yes, we can also make a version that depends on time. Perhaps we can generate data for two different polynomials, and then have input to the polynomials be time 👍

I suggest however that we merge this one as is. Get testing when #165 is done and then extend with more cases after that..

@markusdregi markusdregi merged commit 52590d4 into equinor:master Nov 16, 2018
@ghost ghost removed ready for review labels Nov 16, 2018
@markusdregi markusdregi deleted the poly_stuff branch November 16, 2018 09:18
@andreabrambilla
Copy link
Contributor

yes yes, my comments were more for "future development" ;)
Nice job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants