Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Record base class #1929

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Refactor Record base class #1929

merged 1 commit into from
Jul 27, 2021

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Jul 26, 2021

Making it possible to instantiate a Record object and then defining a class method that returns a specific instance, in this case, either NumericalRecord or BlobRecord

@DanSava DanSava self-assigned this Jul 26, 2021
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanSava DanSava force-pushed the record_base_class_refactor branch from 7beaebc to e8dd317 Compare July 27, 2021 07:23
@DanSava DanSava merged commit 4092406 into main Jul 27, 2021
@DanSava DanSava deleted the record_base_class_refactor branch July 27, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants