Restart failed realizations #206
Conversation
ghost
assigned 
|
I think it is perfectly fine to only support this for |
ManInFez
changed the title
|
I get dizzy trying to review the gui code; but to me this looks ready to be merged. You have actually tested it graphically? |
|
@joakim-hove, yes, I have tested it, but not with a very complicated workflow+FM. Just the example case and the poly_example. I modified the example case to fail on certain realizations. |
|
|
||
| num_successful_realizations = self.ert().getEnkfSimulationRunner().runSimpleStep(self._job_queue, run_context) | ||
| num_successful_realizations += arguments['successful_realizations'] |
There was a problem hiding this comment.
I think the successful_realizations argument is a bit ambiguous. It represents the successfull realizations from a previous round, right? Considering this block out of the Restart PR context, it could be confusing why it's necessary to add that number..
| @@ -9,6 +9,7 @@ class EnsembleSmoother(BaseRunModel): | |||
|
|
|||
| def __init__(self, queue_config): | |||
| super(EnsembleSmoother, self).__init__("Ensemble Smoother", queue_config , phase_count=2) | |||
| self.suport_restart = False | |||
There was a problem hiding this comment.
suport -> support
ManInFez
force-pushed
the
restartFailedRealizations
branch
from
de10d93
to
bb4fa7e
Compare
ManInFez
force-pushed
the
restartFailedRealizations
branch
from
bb4fa7e
to
783cc64
Compare
Remove unused type LARS (Least Angle Regression)
This is a possible direction to go.
The idea is to save the initial state of the active realization mask, and compare it to the completed realization at the end of run_simulations. Then pass back "unfinished realizations".
The problem with this solution is that the workflow can in theory do anything and create different results if only a subset of realizations are active. This can then, in turn, affect the result of running the FM.
resolves #195