Add method getActiveIndexList to class ActiveList #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Jenkins add to whitelist |
oyvindeide
reviewed
Nov 9, 2021
oddvarlia
force-pushed
the
active_list_values
branch
4 times, most recently
from
94e2292
to
0cf0db9
Compare
oddvarlia
force-pushed
the
active_list_values
branch
5 times, most recently
from
ebd244b
to
83292ec
Compare
oddvarlia
changed the title
oyvindeide
reviewed
Nov 28, 2021
|
Two notes:
|
oddvarlia
force-pushed
the
active_list_values
branch
3 times, most recently
from
483c8ce
to
ab0885b
Compare
oyvindeide
reviewed
Dec 1, 2021
oddvarlia
force-pushed
the
active_list_values
branch
3 times, most recently
from
3f1fecc
to
6b601b6
Compare
dafeda
reviewed
Dec 3, 2021
oddvarlia
force-pushed
the
active_list_values
branch
from
6b601b6
to
0569f2f
Compare
Codecov Report
@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
+ Coverage 64.79% 64.80% +0.01%
==========================================
Files 647 647
Lines 53995 54006 +11
Branches 4491 4491
==========================================
+ Hits 34986 34999 +13
Misses 17573 17573
+ Partials 1436 1434 -2
Continue to review full report at Codecov.
|
oddvarlia
force-pushed
the
active_list_values
branch
2 times, most recently
from
8486f2c
to
f76d448
Compare
oyvindeide
reviewed
Dec 10, 2021
oyvindeide
reviewed
Dec 10, 2021
oddvarlia
force-pushed
the
active_list_values
branch
2 times, most recently
from
1c62779
to
f0d457e
Compare
Purpose: Make it possible to check and use active parameters and active observations. Enables better testing of the localisation scripts. Add test for ActiveList.get_active_index_list().
oddvarlia
force-pushed
the
active_list_values
branch
from
f0d457e
to
2ad46eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to python API the function for ActiveList that returns a list of indices of which parameters of a node is active. Add test for this function.
Purpose: Be able to write more precise tests for localisation using ActiveList