-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all long_vector_type uses #2497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a style fix
Codecov Report
@@ Coverage Diff @@
## main #2497 +/- ##
==========================================
- Coverage 63.59% 59.81% -3.79%
==========================================
Files 660 347 -313
Lines 54986 35116 -19870
Branches 4344 3992 -352
==========================================
- Hits 34970 21005 -13965
+ Misses 18702 12774 -5928
- Partials 1314 1337 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments about what part of the diff is covered by the c test suite, but perhaps not truly relevant for this change.
I think just resolving the conflicts should make this PR mergable. |
Seems just a rebase away from being mergeable... |
e7303ce
to
7348207
Compare
No description provided.