Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all long_vector_type uses #2497

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Dec 3, 2021

No description provided.

@pinkwah pinkwah requested a review from dafeda December 3, 2021 12:21
@pinkwah pinkwah self-assigned this Dec 3, 2021
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a style fix

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #2497 (edb288d) into main (a1fdf7f) will decrease coverage by 3.78%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2497      +/-   ##
==========================================
- Coverage   63.59%   59.81%   -3.79%     
==========================================
  Files         660      347     -313     
  Lines       54986    35116   -19870     
  Branches     4344     3992     -352     
==========================================
- Hits        34970    21005   -13965     
+ Misses      18702    12774    -5928     
- Partials     1314     1337      +23     
Impacted Files Coverage Δ
libres/lib/job_queue/job_queue.cpp 9.97% <0.00%> (+0.39%) ⬆️
libres/lib/res_util/block_fs.cpp 52.18% <0.00%> (-2.23%) ⬇️
libres/lib/include/ert/enkf/row_scaling.hpp 0.00% <0.00%> (-100.00%) ⬇️
libres/lib/include/ert/res_util/matrix.hpp 50.00% <0.00%> (-50.00%) ⬇️
res/job_queue/queue_differ.py 71.05% <0.00%> (-21.06%) ⬇️
libres/lib/enkf/value_export.cpp 58.49% <0.00%> (-15.24%) ⬇️
libres/lib/config/conf_util.cpp 55.55% <0.00%> (-14.60%) ⬇️
res/job_queue/queue.py 69.30% <0.00%> (-12.88%) ⬇️
libres/lib/job_queue/forward_model.cpp 48.33% <0.00%> (-7.99%) ⬇️
res/enkf/observations/gen_observation.py 82.27% <0.00%> (-7.60%) ⬇️
... and 462 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fdf7f...edb288d. Read the comment docs.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments about what part of the diff is covered by the c test suite, but perhaps not truly relevant for this change.

libres/lib/res_util/block_fs.cpp Outdated Show resolved Hide resolved
libres/lib/res_util/block_fs.cpp Show resolved Hide resolved
@eivindjahren
Copy link
Contributor

I think just resolving the conflicts should make this PR mergable.

@eivindjahren
Copy link
Contributor

Seems just a rebase away from being mergeable...

@pinkwah pinkwah force-pushed the long-vector branch 3 times, most recently from e7303ce to 7348207 Compare January 3, 2022 13:18
@pinkwah pinkwah merged commit 97348a8 into equinor:main Jan 5, 2022
@pinkwah pinkwah deleted the long-vector branch January 5, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants