Remove unused block_fs cache functionality

[pinkwah]

No description provided.

[codecov-commenter]

Codecov Report

Merging #2499 (611f39c) into main (a1fdf7f) will decrease coverage by 0.00%.
The diff coverage is 88.00%.

@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
- Coverage   63.59%   63.59%   -0.01%     
==========================================
  Files         660      658       -2     
  Lines       54986    54885     -101     
  Branches     4344     4341       -3     
==========================================
- Hits        34970    34904      -66     
+ Misses      18702    18666      -36     
- Partials     1314     1315       +1     

Impacted Files	Coverage Δ
libres/lib/job_queue/job_queue.cpp	9.58% <0.00%> (ø)
libres/lib/res_util/block_fs.cpp	53.51% <88.88%> (-0.90%)	⬇️
libres/lib/enkf/block_fs_driver.cpp	81.35% <100.00%> (-0.97%)	⬇️
libres/lib/enkf/enkf_fs.cpp	71.25% <100.00%> (-0.15%)	⬇️
ert_gui/simulation/run_dialog.py	75.70% <0.00%> (-0.71%)	⬇️
res/enkf/enkf_main.py	83.33% <0.00%> (-0.08%)	⬇️
res/util/__init__.py	100.00% <0.00%> (ø)
libres/lib/res_util/matrix_stat.cpp	0.00% <0.00%> (ø)
res/util/stat.py
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fdf7f...611f39c. Read the comment docs.

[dafeda]

Do you know if ENABLE_CACHE has ever been used to activate cache?

[eivindjahren]

Maybe just a curiosity, but this condition is never met in the c testsuite (in other words, block_fs_fsync is never called in the tests). If that is easy to remedy, it would be very nice :)

[pinkwah]

Jenkins test this please

[eivindjahren]

LGTM