Remove unused res/enkf/plot module

[eivindjahren]

This module is not used in everest or subscript either.

The module was introduce in dc4e44d and used in ert_gui.tools.plot.data and ert_gui.models.connectors. In 26b0a19 both ert_gui.tools.plot.data and ert_gui.tools.models.connectors were removed and replaced by a reference to EnkfMain.

So

  from res.enkf.plot import ObservationGenDataFetcher

  ensemble_data = ObservationGenDataFetcher(self.ert()).fetchData(key, cases)

became

gen_obs = ERT.ert.getObservations().getTypedKeylist(EnkfObservationImplementationType.GEN_OBS)

where ERT.ert is EnkfMain.

[codecov-commenter]

Codecov Report

Merging #2509 (538f3c2) into main (b8e35d1) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
+ Coverage   63.79%   64.21%   +0.42%     
==========================================
  Files         658      648      -10     
  Lines       54927    54492     -435     
  Branches     4343     4393      +50     
==========================================
- Hits        35041    34994      -47     
+ Misses      18564    18172     -392     
- Partials     1322     1326       +4     

Impacted Files	Coverage Δ
ert_gui/ertwidgets/validationsupport.py	79.45% <0.00%> (-19.18%)	⬇️
libres/lib/enkf/local_obsdata_node.cpp	84.61% <0.00%> (-4.41%)	⬇️
res/enkf/local_obsdata.py	60.43% <0.00%> (-3.85%)	⬇️
ert_gui/ertwidgets/__init__.py	75.00% <0.00%> (-2.28%)	⬇️
res/enkf/local_obsdata_node.py	86.48% <0.00%> (-1.61%)	⬇️
libres/lib/enkf/block_fs_driver.cpp	81.76% <0.00%> (-0.56%)	⬇️
libres/lib/python/init.cpp	0.00% <0.00%> (ø)
libres/lib/enkf/obs_vector.cpp	37.06% <0.00%> (ø)
libres/lib/enkf/enkf_analysis.cpp	58.82% <0.00%> (ø)
libres/lib/enkf/local_obsdata.cpp	48.10% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e35d1...538f3c2. Read the comment docs.

[oyvindeide]

LGTM! Thanks for cleaning, also had the indirect benefit of increased test coverage ;)