Remove res/ interoperability with python 2 #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
remove_python2_object
branch
2 times, most recently
from
a43d62a
to
011e7ad
Compare
Codecov Report
@@ Coverage Diff @@
## main #2518 +/- ##
==========================================
- Coverage 63.73% 63.73% -0.01%
==========================================
Files 658 658
Lines 54904 54902 -2
Branches 4393 4393
==========================================
- Hits 34994 34991 -3
Misses 18584 18584
- Partials 1326 1327 +1
Continue to review full report at Codecov.
|
eivindjahren
force-pushed
the
remove_python2_object
branch
4 times, most recently
from
d3ec03b
to
fa48ac7
Compare
eivindjahren
changed the title
eivindjahren
force-pushed
the
remove_python2_object
branch
2 times, most recently
from
68b03d3
to
f98d89a
Compare
eivindjahren
force-pushed
the
remove_python2_object
branch
from
f98d89a
to
843dda2
Compare
eivindjahren
force-pushed
the
remove_python2_object
branch
from
843dda2
to
0939193
Compare
pinkwah
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of
six, super with arguments and inheritance fromobjectwhich were left over from interoperability with python 2. python2 interoperability is spotty in any case assixis not part ofinstall_requiresand f-strings are used in some places.