Simulation progress improvments #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
There was a problem hiding this comment.
Found an error that kinda messed up the testing a bit (ref #253 ), but unrelated to this.
Look through the comments and then this should be good to go.
| @@ -2,7 +2,7 @@ | |||
| import time | |||
| try: | |||
| from PyQt4.QtCore import QTimer, pyqtSignal, QVariant, Qt, QAbstractTableModel | |||
| from PyQt4.QtGui import QWidget, QPainter, QColor, QFrame, QGridLayout, QImage, QDialog, QTableView, QLabel | |||
| from PyQt4.QtGui import QWidget, QPainter, QColor, QFrame, QGridLayout, QImage, QDialog, QTableView, QLabel, QPen | |||
There was a problem hiding this comment.
Wouldn't you need import of QPen both for pyqt4 and 5?
There was a problem hiding this comment.
and for the others as well? e.g. QPainter
There was a problem hiding this comment.
A quick test just to verify at least imports would be nice, ert tests are run with both python2.7/pyqt4 and python4/pyqt5
| @@ -81,12 +88,26 @@ def paintEvent(self, event): | |||
| for index, (iens, progress) in enumerate(self._current_progress): | |||
| y = int(iens / self.grid_width) | |||
| x = int(iens - (y * self.grid_width)) | |||
|
|
|||
| #painter.drawText(x * cell_width + cell_width / 2, y * cell_height + cell_height / 2, str(iens)) | |||
There was a problem hiding this comment.
trailing comment :)
markusdregi
reviewed
Feb 20, 2019
| @@ -52,6 +52,13 @@ def set_progress(self, progress, iteration): | |||
| self._current_iteration = iteration | |||
| self.update() | |||
|
|
|||
| def has_realization_failed(self, progress): | |||
| for job in progress: | |||
There was a problem hiding this comment.
return any((job.status == 'Failure' for job in progress))?
lars-petter-hauge
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #251