Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stringvector_type with stl::vector #2527

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

oyvindeide
Copy link
Collaborator

Issue
Resolves #2515

@oyvindeide oyvindeide marked this pull request as draft December 8, 2021 08:52
@oyvindeide oyvindeide force-pushed the replace_string_list branch 6 times, most recently from af814d7 to 57d3574 Compare December 8, 2021 13:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #2527 (14b2c49) into main (94d7347) will decrease coverage by 0.10%.
The diff coverage is 30.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
- Coverage   64.82%   64.71%   -0.11%     
==========================================
  Files         648      651       +3     
  Lines       54188    54234      +46     
  Branches     4517     4597      +80     
==========================================
- Hits        35127    35098      -29     
- Misses      17655    17702      +47     
- Partials     1406     1434      +28     
Impacted Files Coverage Δ
libres/lib/analysis/update.cpp 0.00% <0.00%> (ø)
libres/lib/include/ert/python.hpp 0.00% <ø> (ø)
libres/lib/python/enkf_fs_manager.cpp 0.00% <0.00%> (ø)
libres/lib/python/ensemble_config.cpp 0.00% <0.00%> (ø)
libres/lib/python/init.cpp 0.00% <0.00%> (ø)
libres/lib/python/py_conversion.cpp 0.00% <0.00%> (ø)
res/enkf/enkf_state.py 73.68% <0.00%> (ø)
libres/lib/enkf/enkf_state.cpp 67.09% <36.36%> (-2.81%) ⬇️
libres/lib/enkf/enkf_main_manage_fs.cpp 56.68% <46.66%> (-2.67%) ⬇️
libres/lib/enkf/ensemble_config.cpp 54.16% <50.00%> (-0.59%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d7347...14b2c49. Read the comment docs.

@oyvindeide oyvindeide force-pushed the replace_string_list branch 3 times, most recently from 8c43a6d to e966225 Compare December 8, 2021 22:25
@oyvindeide oyvindeide marked this pull request as ready for review December 8, 2021 22:26
res/enkf/ensemble_config.py Outdated Show resolved Hide resolved
@oyvindeide oyvindeide self-assigned this Dec 10, 2021
@oyvindeide oyvindeide force-pushed the replace_string_list branch 8 times, most recently from 8667f75 to 28298b8 Compare December 21, 2021 15:31
@oyvindeide
Copy link
Collaborator Author

oyvindeide commented Dec 22, 2021

CI failure is unrelated:
ImportError: cannot import name BeartypeDecorHintPepDeprecatedWarning

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes, but looks solid 👍

@oyvindeide
Copy link
Collaborator Author

A lot of changes, but looks solid 👍

Yes 😬 I agree the diff is quite large, but I think this is the minimum I could get away with without doing conversions from ecl types to std::

@oyvindeide
Copy link
Collaborator Author

test this please

@oyvindeide oyvindeide merged commit 400611c into equinor:main Jan 5, 2022
@oyvindeide oyvindeide deleted the replace_string_list branch February 24, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace stringlist_type with std::vector<string> in ensemble_config
6 participants