-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace stringvector_type with stl::vector #2527
Conversation
af814d7
to
57d3574
Compare
Codecov Report
@@ Coverage Diff @@
## main #2527 +/- ##
==========================================
- Coverage 64.82% 64.71% -0.11%
==========================================
Files 648 651 +3
Lines 54188 54234 +46
Branches 4517 4597 +80
==========================================
- Hits 35127 35098 -29
- Misses 17655 17702 +47
- Partials 1406 1434 +28
Continue to review full report at Codecov.
|
57d3574
to
09e6640
Compare
8c43a6d
to
e966225
Compare
8667f75
to
28298b8
Compare
28298b8
to
63fc926
Compare
CI failure is unrelated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of changes, but looks solid 👍
63fc926
to
14b2c49
Compare
Yes 😬 I agree the diff is quite large, but I think this is the minimum I could get away with without doing conversions from |
test this please |
Issue
Resolves #2515