Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ert_gui/newconfig.py #2533

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Dec 9, 2021

Issue
Resolves #2524

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #2533 (005c97a) into main (0c82efa) will decrease coverage by 3.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
- Coverage   64.21%   60.43%   -3.79%     
==========================================
  Files         648      335     -313     
  Lines       54517    37308   -17209     
  Branches     4401     4401              
==========================================
- Hits        35010    22547   -12463     
+ Misses      18176    13429    -4747     
- Partials     1331     1332       +1     
Impacted Files Coverage Δ
res/job_queue/queue_differ.py 71.05% <0.00%> (-21.06%) ⬇️
res/job_queue/queue.py 69.40% <0.00%> (-12.83%) ⬇️
res/enkf/observations/gen_observation.py 82.50% <0.00%> (-7.50%) ⬇️
res/enkf/export/gen_kw_collector.py 94.11% <0.00%> (-5.89%) ⬇️
res/enkf/key_manager.py 91.42% <0.00%> (-5.72%) ⬇️
res/job_queue/forward_model_status.py 88.75% <0.00%> (-5.00%) ⬇️
res/enkf/local_updatestep.py 77.41% <0.00%> (-3.23%) ⬇️
res/enkf/enkf_fs_manager.py 88.27% <0.00%> (-2.76%) ⬇️
res/enkf/enkf_obs.py 67.85% <0.00%> (-2.68%) ⬇️
res/job_queue/job_status_type_enum.py 97.36% <0.00%> (-2.64%) ⬇️
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c82efa...005c97a. Read the comment docs.

@eivindjahren eivindjahren merged commit be5cb72 into main Dec 9, 2021
@eivindjahren eivindjahren deleted the remove_unused_newconfig branch December 9, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewConfigDialog is unused
3 participants