Delete unused arg_pack.h

[dafeda]

Issue
Resolves #2594

Pre review checklist

• [ x] Added appropriate labels

[codecov-commenter]

Codecov Report

Merging #2595 (e884fcc) into main (6a48a2c) will decrease coverage by 13.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2595       +/-   ##
===========================================
- Coverage   64.52%   50.86%   -13.66%     
===========================================
  Files         646      160      -486     
  Lines       54500    24874    -29626     
  Branches     4516     4199      -317     
===========================================
- Hits        35164    12653    -22511     
+ Misses      17949    10825     -7124     
- Partials     1387     1396        +9     

Impacted Files	Coverage Δ
libres/lib/include/ert/enkf/row_scaling.hpp	0.00% <0.00%> (-100.00%)	⬇️
libres/lib/include/ert/res_util/matrix.hpp	50.00% <0.00%> (-50.00%)	⬇️
libres/lib/enkf/value_export.cpp	58.49% <0.00%> (-15.24%)	⬇️
libres/lib/config/conf_util.cpp	55.55% <0.00%> (-14.60%)	⬇️
libres/lib/job_queue/forward_model.cpp	48.33% <0.00%> (-7.99%)	⬇️
libres/lib/analysis/ies/ies_enkf_data.cpp	83.00% <0.00%> (-7.06%)	⬇️
libres/lib/res_util/es_testdata.cpp	61.14% <0.00%> (-6.72%)	⬇️
libres/lib/job_queue/job_kw_definitions.cpp	60.00% <0.00%> (-6.67%)	⬇️
libres/lib/enkf/enkf_util.cpp	50.00% <0.00%> (-6.53%)	⬇️
libres/lib/enkf/enkf_main_ensemble.cpp	63.33% <0.00%> (-5.90%)	⬇️
... and 619 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a48a2c...e884fcc. Read the comment docs.

[eivindjahren]

weirdly this seems to change the behavior of some ert_gui tests. May be worth having a look.

[dafeda]

weirdly this seems to change the behavior of some ert_gui tests. May be worth having a look.

All tests have passed, which ones have changed behaviour?

[eivindjahren]

All tests have passed, which ones have changed behaviour?

Not sure but coverage no longer hits ert_gui.ertwidgets.validationsupport::presentError. Might be a fluke. Might be that an error related to arg_pack.h no longer makes it way to the gui which I count as a good thing :)

[eivindjahren]

Btw, the coverage changes I am looking at are here: https://app.codecov.io/gh/equinor/ert/compare/2595/changes