Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespace for analysis update #2599

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

eivindjahren
Copy link
Contributor

Issue
Resolves #2575

Approach
Uses cpp namespace for analysis/update. Also removes static as we would like to test these functions and renames get_active_size to conform to standard cpp naming practices.

Pre review checklist

  • Added appropriate labels

@eivindjahren eivindjahren added payback maintenance Not a bug now but could be one day, repaying technical debt analysis labels Dec 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #2599 (59b91cb) into main (e0b23c6) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
+ Coverage   60.53%   60.56%   +0.03%     
==========================================
  Files         336      336              
  Lines       37249    34747    -2502     
  Branches     4515     4229     -286     
==========================================
- Hits        22549    21046    -1503     
+ Misses      13314    12305    -1009     
- Partials     1386     1396      +10     
Impacted Files Coverage Δ
libres/lib/analysis/update.cpp 0.00% <0.00%> (ø)
libres/lib/enkf/enkf_main.cpp 52.64% <0.00%> (-0.68%) ⬇️
libres/lib/include/ert/enkf/row_scaling.hpp 0.00% <0.00%> (-100.00%) ⬇️
libres/lib/include/ert/res_util/matrix.hpp 50.00% <0.00%> (-50.00%) ⬇️
libres/lib/enkf/value_export.cpp 58.49% <0.00%> (-15.24%) ⬇️
libres/lib/config/conf_util.cpp 55.55% <0.00%> (-14.60%) ⬇️
libres/lib/job_queue/forward_model.cpp 48.33% <0.00%> (-7.99%) ⬇️
libres/lib/analysis/ies/ies_enkf_data.cpp 83.00% <0.00%> (-7.06%) ⬇️
libres/lib/res_util/es_testdata.cpp 61.14% <0.00%> (-6.72%) ⬇️
libres/lib/job_queue/job_kw_definitions.cpp 60.00% <0.00%> (-6.67%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b23c6...59b91cb. Read the comment docs.

@eivindjahren eivindjahren force-pushed the use_namespace_for_analysis_update branch from 9f3b8e0 to 59b91cb Compare December 15, 2021 13:23
@eivindjahren eivindjahren marked this pull request as ready for review December 15, 2021 13:27
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespaces are nice, LGTM 👍

@eivindjahren eivindjahren merged commit 040dd3a into main Dec 15, 2021
@eivindjahren eivindjahren deleted the use_namespace_for_analysis_update branch December 15, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt payback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile analysis/update as C++
3 participants