Fix failure when using pbs driver #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference to self._on_task_failure caused the entire PrefectEnsemble to be pickled. This is not intended, nor is it safe, in particular because the Executor might contain thread locks. This commit moves the _on_task_failure function out of the PrefectEnsemble object, and rather binds only the ee_id before the task is pickled.
sondreso
force-pushed
the
fix-pbs-driver-failure
branch
from
cb096a6
to
306fe50
Compare
markusdregi
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2687
Approach
Move
_on_task_failurefunction out ofPrefectEnsembleThe reference to
self._on_task_failurecaused the entirePrefectEnsembleto be pickled. This is not intended, nor is it safe, in particular
because the Executor might contain thread locks. This commit moves the
_on_task_failurefunction out of thePrefectEnsembleobject, and ratherbinds only the
ee_idbefore the task is pickled.Pre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml