Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask for storage as an extras in CI #2695

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 12, 2022

Issue
Resolves warning in CI on missing extas in ERT.

This is a followup to 28d777d#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7

Approach
rm. ert-storage is an explicit requirement now.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@berland berland added payback maintenance Not a bug now but could be one day, repaying technical debt labels Jan 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2695 (78679ca) into main (1b7390a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2695   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files         651      651           
  Lines       53917    53917           
  Branches     4610     4610           
=======================================
+ Hits        35079    35082    +3     
+ Misses      17360    17357    -3     
  Partials     1478     1478           
Impacted Files Coverage Δ
libres/lib/res_util/block_fs.cpp 53.38% <0.00%> (ø)
ert_shared/status/tracker/legacy.py 87.83% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7390a...78679ca. Read the comment docs.

@berland berland enabled auto-merge (rebase) January 12, 2022 09:03
@berland berland merged commit 79ce8ac into equinor:main Jan 12, 2022
@berland berland deleted the no_storage_extras branch January 13, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt payback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants