-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ResLog with Python logging #2710
Conversation
04f5d47
to
32e7bed
Compare
1850898
to
1527aff
Compare
25af4cc
to
e4c2b61
Compare
4cf6521
to
8f94e19
Compare
This looks like a solid piece of work 👍 Would you not say that LOG keywords are not deprecated but ignored or not supported? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Real nice 👍
Codecov Report
@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 65.27% 65.16% -0.12%
==========================================
Files 653 649 -4
Lines 53121 52803 -318
Branches 4769 4744 -25
==========================================
- Hits 34677 34409 -268
+ Misses 16852 16809 -43
+ Partials 1592 1585 -7
Continue to review full report at Codecov.
|
0ed2075
to
2b5aac9
Compare
2b5aac9
to
8ef32fc
Compare
We've recently implemented Python logging in C++ via pybind. ResLog was the previous attempt at this.
This PR deprecates
LOG_LEVEL
andLOG_FILE
ERT config keys as well.TODO:
LOG_LEVEL
LOG_FILE
logging.hpp
testingILogger
rather thanreslog
.