Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ResLog with Python logging #2710

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Jan 13, 2022

We've recently implemented Python logging in C++ via pybind. ResLog was the previous attempt at this.

This PR deprecates LOG_LEVEL and LOG_FILE ERT config keys as well.

TODO:

  • Deprecate LOG_LEVEL
  • Deprecate LOG_FILE
  • Generalise logging.hpp testing
  • Fix old_tests to use ILogger rather than reslog.

@pinkwah pinkwah self-assigned this Jan 13, 2022
@pinkwah pinkwah force-pushed the remove-reslog branch 2 times, most recently from 1850898 to 1527aff Compare January 27, 2022 08:27
@pinkwah pinkwah force-pushed the remove-reslog branch 4 times, most recently from 25af4cc to e4c2b61 Compare February 1, 2022 11:50
@pinkwah pinkwah marked this pull request as ready for review February 1, 2022 13:25
@pinkwah pinkwah requested a review from dafeda February 2, 2022 11:25
@ManInFez
Copy link
Contributor

ManInFez commented Feb 3, 2022

This looks like a solid piece of work 👍 Would you not say that LOG keywords are not deprecated but ignored or not supported?

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nice 👍

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #2710 (8ef32fc) into main (5882f0c) will decrease coverage by 0.11%.
The diff coverage is 19.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2710      +/-   ##
==========================================
- Coverage   65.27%   65.16%   -0.12%     
==========================================
  Files         653      649       -4     
  Lines       53121    52803     -318     
  Branches     4769     4744      -25     
==========================================
- Hits        34677    34409     -268     
+ Misses      16852    16809      -43     
+ Partials     1592     1585       -7     
Impacted Files Coverage Δ
.../ertwidgets/models/analysismodulevariablesmodel.py 56.25% <ø> (ø)
ert_shared/ide/keywords/run_keywords.py 100.00% <ø> (ø)
libres/lib/analysis/update.cpp 40.62% <0.00%> (+0.26%) ⬆️
libres/lib/config/config_parser.cpp 82.60% <0.00%> (-0.61%) ⬇️
libres/lib/enkf/analysis_config.cpp 51.70% <0.00%> (-0.35%) ⬇️
libres/lib/enkf/config_keys.cpp 0.81% <ø> (+0.01%) ⬆️
libres/lib/enkf/enkf_main.cpp 51.59% <0.00%> (-1.09%) ⬇️
libres/lib/enkf/enkf_main_jobs.cpp 15.28% <0.00%> (+0.05%) ⬆️
libres/lib/enkf/enkf_main_manage_fs.cpp 63.00% <0.00%> (ø)
libres/lib/enkf/ert_workflow_list.cpp 81.12% <0.00%> (+0.09%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5882f0c...8ef32fc. Read the comment docs.

@pinkwah pinkwah force-pushed the remove-reslog branch 2 times, most recently from 0ed2075 to 2b5aac9 Compare February 9, 2022 08:37
@pinkwah pinkwah merged commit 1645f3e into equinor:main Feb 9, 2022
@pinkwah pinkwah deleted the remove-reslog branch February 9, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants