-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused class History #2718
Conversation
60d3ccb
to
3cea786
Compare
test this please |
Are you sure history observations are never used? |
This is never created in python outside of tests, but is retured from other objects.
3cea786
to
263fb0a
Compare
History observations are used, but this is not that. The only bit of production code that is actually being deleted is this:
|
Codecov Report
@@ Coverage Diff @@
## main #2718 +/- ##
==========================================
+ Coverage 65.05% 65.35% +0.29%
==========================================
Files 651 651
Lines 53634 53606 -28
Branches 4724 4733 +9
==========================================
+ Hits 34892 35034 +142
+ Misses 17260 17037 -223
- Partials 1482 1535 +53
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue
Drive by cleaning while working on seperate issue.
Pre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml