Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused class History #2718

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jan 17, 2022

Issue
Drive by cleaning while working on seperate issue.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@oyvindeide oyvindeide added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Jan 17, 2022
@oyvindeide oyvindeide self-assigned this Jan 17, 2022
@oyvindeide oyvindeide force-pushed the remove_history branch 3 times, most recently from 60d3ccb to 3cea786 Compare January 17, 2022 09:00
@oyvindeide
Copy link
Collaborator Author

test this please

@ManInFez
Copy link
Contributor

Are you sure history observations are never used?

This is never created in python outside of tests, but is retured
from other objects.
@oyvindeide
Copy link
Collaborator Author

Are you sure history observations are never used?

History observations are used, but this is not that. The only bit of production code that is actually being deleted is this:

    @staticmethod
    def get_source_string(history_source_type: HistorySourceEnum):
        """
        @type history_source_type: HistorySourceEnum
        @rtype: str
        """
        return History._get_source_string(history_source_type)

@oyvindeide oyvindeide changed the title Remove unused module history Remove unused class History Jan 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2718 (263fb0a) into main (0d2f714) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2718      +/-   ##
==========================================
+ Coverage   65.05%   65.35%   +0.29%     
==========================================
  Files         651      651              
  Lines       53634    53606      -28     
  Branches     4724     4733       +9     
==========================================
+ Hits        34892    35034     +142     
+ Misses      17260    17037     -223     
- Partials     1482     1535      +53     
Impacted Files Coverage Δ
res/enkf/enkf_obs.py 72.63% <ø> (+2.09%) ⬆️
res/sched/__init__.py 100.00% <ø> (ø)
libres/lib/analysis/std_enkf.cpp 59.63% <0.00%> (-4.06%) ⬇️
ert_gui/simulation/run_dialog.py 75.70% <0.00%> (-0.71%) ⬇️
libres/lib/enkf/block_fs_driver.cpp 81.35% <0.00%> (-0.57%) ⬇️
libres/lib/analysis/ies/ies.cpp 56.25% <0.00%> (-0.12%) ⬇️
libres/lib/job_queue/lsf_driver.cpp 45.42% <0.00%> (-0.07%) ⬇️
libres/lib/include/ert/res_util/string.hpp 69.23% <0.00%> (ø)
libres/lib/res_util/block_fs.cpp 53.82% <0.00%> (+0.29%) ⬆️
libres/lib/analysis/enkf_linalg.cpp 46.37% <0.00%> (+0.66%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2f714...263fb0a. Read the comment docs.

Copy link
Contributor

@ManInFez ManInFez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyvindeide oyvindeide merged commit 7e61618 into equinor:main Jan 19, 2022
@oyvindeide oyvindeide deleted the remove_history branch January 19, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants