Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default gen_kw_export_name with pybind #2719

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jan 17, 2022

Drive by simplification while working on other parts of the code.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #2719 (c99aa74) into main (09152c9) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2719      +/-   ##
==========================================
- Coverage   65.34%   65.32%   -0.02%     
==========================================
  Files         651      650       -1     
  Lines       53655    53657       +2     
  Branches     4724     4724              
==========================================
- Hits        35060    35051       -9     
- Misses      17058    17070      +12     
+ Partials     1537     1536       -1     
Impacted Files Coverage Δ
libres/lib/python/enkf_defaults.cpp 0.00% <0.00%> (ø)
libres/lib/python/init.cpp 0.00% <0.00%> (ø)
res/enkf/__init__.py 100.00% <ø> (ø)
res/fm/templating/template_render.py 84.00% <100.00%> (-0.32%) ⬇️
ert_gui/ertwidgets/validationsupport.py 79.45% <0.00%> (-19.18%) ⬇️
ert_gui/ertwidgets/__init__.py 75.00% <0.00%> (-2.28%) ⬇️
libres/lib/analysis/std_enkf.cpp 62.42% <0.00%> (-1.28%) ⬇️
libres/lib/enkf/gen_kw.cpp 59.02% <0.00%> (-0.49%) ⬇️
libres/lib/enkf/enkf_node.cpp 52.16% <0.00%> (-0.26%) ⬇️
libres/lib/res_util/block_fs.cpp 53.97% <0.00%> (+0.14%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09152c9...c99aa74. Read the comment docs.

libres/lib/python/enkf_defaults.cpp Outdated Show resolved Hide resolved
libres/lib/include/ert/enkf/enkf_defaults.hpp Outdated Show resolved Hide resolved
@oyvindeide oyvindeide force-pushed the remove_prototype branch 3 times, most recently from a850375 to 8c12fb0 Compare January 17, 2022 10:47
@ManInFez
Copy link
Contributor

Since there are no issue connected to this, it would be good with a small description describing the reasoning behind this :)

@oyvindeide
Copy link
Collaborator Author

oyvindeide commented Jan 17, 2022

Since there are no issue connected to this, it would be good with a small description describing the reasoning behind this :)

True, I dont have that much of a reason really. I was working to alight some analysis stuff in python and c++, and came across this as a simplification.

Edit: added that to the PR text

@oyvindeide oyvindeide merged commit 2c1b243 into equinor:main Jan 18, 2022
@oyvindeide oyvindeide deleted the remove_prototype branch January 18, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants