Add tests for save/load parameters with rowscaling #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInFez
force-pushed
the
test_save_load_rowscaling_paramteters
branch
from
4cbd02f
to
52a5dfa
Compare
Codecov Report
@@ Coverage Diff @@
## main #2721 +/- ##
==========================================
+ Coverage 65.23% 65.28% +0.04%
==========================================
Files 651 651
Lines 53549 53556 +7
Branches 4784 4786 +2
==========================================
+ Hits 34935 34964 +29
+ Misses 17041 16988 -53
- Partials 1573 1604 +31
Continue to review full report at Codecov.
|
dafeda
reviewed
Jan 21, 2022
| ministep, row_scaling_list); | ||
|
|
||
| WHEN("loading parameters from enkf_fs") { | ||
| auto parmeter_matrices = analysis::load_row_scaling_parameters( |
There was a problem hiding this comment.
parameter_matrices?
Pedantizm 🚀
There was a problem hiding this comment.
it is potentially a list of matrices 🤷
There was a problem hiding this comment.
I was thinking that parmeter should be parameter...
No biggie 😄
dafeda
reviewed
Jan 21, 2022
ManInFez
force-pushed
the
test_save_load_rowscaling_paramteters
branch
2 times, most recently
from
54fcd99
to
5d3d51b
Compare
ManInFez
force-pushed
the
test_save_load_rowscaling_paramteters
branch
from
5d3d51b
to
d1a32f8
Compare
ManInFez
force-pushed
the
test_save_load_rowscaling_paramteters
branch
from
d1a32f8
to
12cc1d1
Compare
|
Test this please! |
3 similar comments
|
Test this please! |
|
Test this please! |
|
Test this please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2582
Resolves #2584
Approach
Roundtrip test for a matrix with rowscaling attached
Pre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml