Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling around ert3 initialization #2779

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Jan 26, 2022

Issue
Resolves #2760

Approach

  • Add error handling for the case that ert3 init fails to connect to the storage.
  • Add error handling for the case that ert3 tries to use a storage that not has been initialized properly.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@verveerpj verveerpj self-assigned this Jan 26, 2022
@verveerpj verveerpj marked this pull request as draft January 26, 2022 12:40
@verveerpj verveerpj marked this pull request as ready for review January 26, 2022 12:43
@verveerpj verveerpj force-pushed the bug__ensemble_records__missing branch from afb354e to 35506c9 Compare January 26, 2022 13:21
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only two minor comments

ert/storage/_storage.py Outdated Show resolved Hide resolved
ert3/console/_console.py Outdated Show resolved Hide resolved
@verveerpj verveerpj force-pushed the bug__ensemble_records__missing branch from 35506c9 to a31e803 Compare January 26, 2022 14:26
@verveerpj verveerpj force-pushed the bug__ensemble_records__missing branch from a31e803 to f976dcd Compare January 26, 2022 14:40
@codecov-commenter
Copy link

Codecov Report

Merging #2779 (f976dcd) into main (f20fec4) will decrease coverage by 0.01%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
- Coverage   65.20%   65.19%   -0.02%     
==========================================
  Files         652      652              
  Lines       53630    53643      +13     
  Branches     4818     4818              
==========================================
  Hits        34970    34970              
- Misses      17058    17067       +9     
- Partials     1602     1606       +4     
Impacted Files Coverage Δ
ert/storage/__init__.py 100.00% <ø> (ø)
ert3/console/_console.py 88.29% <40.00%> (-1.26%) ⬇️
ert3/workspace/_workspace.py 89.24% <66.66%> (-0.76%) ⬇️
ert/storage/_storage.py 88.85% <83.33%> (-0.10%) ⬇️
libres/lib/res_util/arg_pack.cpp 59.78% <0.00%> (-1.06%) ⬇️
ert_gui/simulation/run_dialog.py 75.70% <0.00%> (-0.71%) ⬇️
libres/lib/enkf/gen_kw.cpp 59.02% <0.00%> (-0.49%) ⬇️
libres/lib/res_util/matrix.cpp 65.40% <0.00%> (-0.28%) ⬇️
libres/lib/enkf/enkf_node.cpp 52.16% <0.00%> (-0.26%) ⬇️
libres/lib/res_util/block_fs.cpp 53.97% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20fec4...f976dcd. Read the comment docs.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@verveerpj verveerpj merged commit 4f176e0 into main Jan 26, 2022
@verveerpj verveerpj deleted the bug__ensemble_records__missing branch January 26, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running ert3 experiments gives error message about __ensemble_records__
3 participants