Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmake feature tests #2791

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Jan 27, 2022

Pre review checklist

  • [x ] Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

The point of these tests is to make sure the compiler has
all the features we need.
We support a limited set of compilers which makes
these tests unnecessary.
@dafeda dafeda added the maintenance Not a bug now but could be one day, repaying technical debt label Jan 27, 2022
@dafeda dafeda requested a review from pinkwah January 27, 2022 09:03
@dafeda dafeda closed this Jan 27, 2022
@dafeda dafeda reopened this Jan 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #2791 (1c32c25) into main (ac2ea6e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2791   +/-   ##
=======================================
  Coverage   65.16%   65.17%           
=======================================
  Files         652      652           
  Lines       53645    53645           
  Branches     4818     4818           
=======================================
+ Hits        34958    34961    +3     
  Misses      17080    17080           
+ Partials     1607     1604    -3     
Impacted Files Coverage Δ
libres/lib/res_util/block_fs.cpp 53.97% <0.00%> (+0.29%) ⬆️
libres/lib/enkf/gen_kw.cpp 59.51% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2ea6e...1c32c25. Read the comment docs.

@dafeda dafeda closed this Jan 27, 2022
@dafeda dafeda reopened this Jan 27, 2022
@dafeda
Copy link
Contributor Author

dafeda commented Jan 27, 2022

test ert please

@dafeda
Copy link
Contributor Author

dafeda commented Jan 27, 2022

test this please

@dafeda dafeda merged commit dc2a04d into equinor:main Jan 27, 2022
@dafeda dafeda deleted the remove_cmake_feature_tests branch January 27, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants