-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor summary collector #2802
Refactor summary collector #2802
Conversation
13252c0
to
325d40c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
- Coverage 65.20% 65.14% -0.07%
==========================================
Files 653 654 +1
Lines 53480 53515 +35
Branches 4791 4804 +13
==========================================
- Hits 34874 34862 -12
- Misses 17007 17050 +43
- Partials 1599 1603 +4
Continue to review full report at Codecov.
|
b782c62
to
fcbcea8
Compare
c1829e0
to
c195e8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good
66aa583
to
47737d4
Compare
47737d4
to
9b5faa4
Compare
Issue
Resolves #2735
Approach
Improves the performance by moving more of the code filling out the summary dataframe from python back to c++.
Pre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml