Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop threads when collecting summary-data #2808

Conversation

BjarneHerland
Copy link
Contributor

@BjarneHerland BjarneHerland commented Jan 28, 2022

Issue
Fixes #2650
Result of tests and discussion in #2650

Pre review checklist

  • Added appropriate labels

@BjarneHerland BjarneHerland added the improvement Something nice to have, that will make life easier for developers or users or both. label Jan 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #2808 (d728f6e) into main (a0e3887) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head d728f6e differs from pull request most recent head c2188d5. Consider uploading reports for the commit c2188d5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
+ Coverage   65.31%   65.37%   +0.05%     
==========================================
  Files         652      652              
  Lines       53503    53495       -8     
  Branches     4752     4752              
==========================================
+ Hits        34947    34972      +25     
+ Misses      16948    16918      -30     
+ Partials     1608     1605       -3     
Impacted Files Coverage Δ
libres/lib/enkf/enkf_plot_data.cpp 27.86% <0.00%> (+3.23%) ⬆️
libres/lib/res_util/block_fs.cpp 53.97% <0.00%> (+0.29%) ⬆️
ert_shared/models/base_run_model.py 82.21% <0.00%> (+0.39%) ⬆️
libres/lib/enkf/gen_kw.cpp 59.51% <0.00%> (+0.48%) ⬆️
ert_shared/status/tracker/legacy.py 86.24% <0.00%> (+1.05%) ⬆️
ert_gui/ertwidgets/__init__.py 77.27% <0.00%> (+2.27%) ⬆️
res/job_queue/forward_model_status.py 93.75% <0.00%> (+5.00%) ⬆️
ert_gui/ertwidgets/validationsupport.py 98.63% <0.00%> (+19.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e3887...c2188d5. Read the comment docs.

@BjarneHerland
Copy link
Contributor Author

test this please

@BjarneHerland BjarneHerland force-pushed the drop_threads_when_collecting_summarydata branch 2 times, most recently from d728f6e to c2188d5 Compare January 31, 2022 08:23
@BjarneHerland
Copy link
Contributor Author

test this please

@BjarneHerland BjarneHerland force-pushed the drop_threads_when_collecting_summarydata branch from c2188d5 to 07f457f Compare January 31, 2022 09:23
@pinkwah
Copy link
Contributor

pinkwah commented Jan 31, 2022

Looks good!

Also remove:

  • void *enkf_plot_tvector_load__(void *arg) {
    arg_pack_type *arg_pack = arg_pack_safe_cast(arg);
    enkf_plot_tvector_type *tvector =
    (enkf_plot_tvector_type *)arg_pack_iget_ptr(arg_pack, 0);
    enkf_fs_type *fs = (enkf_fs_type *)arg_pack_iget_ptr(arg_pack, 1);
    const char *index_key = (const char *)arg_pack_iget_ptr(arg_pack, 2);
    enkf_plot_tvector_load(tvector, fs, index_key);
    return NULL;
    }
  • void *enkf_plot_tvector_load__(void *arg);

@BjarneHerland BjarneHerland force-pushed the drop_threads_when_collecting_summarydata branch from 07f457f to 276b287 Compare January 31, 2022 10:03
Copy link
Contributor

@TerryHannant TerryHannant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sondreso sondreso changed the title Drop threads when collecting summary-data. Fixes #2650 Drop threads when collecting summary-data Jan 31, 2022
@BjarneHerland
Copy link
Contributor Author

test this please

@BjarneHerland BjarneHerland merged commit 35ae847 into equinor:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something nice to have, that will make life easier for developers or users or both.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the use of threadpool loading data
5 participants