Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize test instead of having duplicate #2810

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jan 28, 2022

Issue
Some cleaning up of tests.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #2810 (40d09e0) into main (1ab7882) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2810      +/-   ##
==========================================
- Coverage   65.23%   65.20%   -0.04%     
==========================================
  Files         651      653       +2     
  Lines       53549    53496      -53     
  Branches     4784     4790       +6     
==========================================
- Hits        34935    34883      -52     
+ Misses      17041    17011      -30     
- Partials     1573     1602      +29     
Impacted Files Coverage Δ
res/enkf/plot_data/ensemble_plot_gen_kw.py 53.70% <0.00%> (-29.63%) ⬇️
libres/lib/enkf/row_scaling.cpp 58.94% <0.00%> (-12.64%) ⬇️
...es/enkf/plot_data/ensemble_plot_gen_data_vector.py 57.14% <0.00%> (-9.53%) ⬇️
res/enkf/config/gen_data_config.py 76.05% <0.00%> (-7.05%) ⬇️
ert_shared/models/single_test_run.py 80.00% <0.00%> (-6.67%) ⬇️
res/job_queue/forward_model_status.py 88.75% <0.00%> (-5.00%) ⬇️
res/enkf/plot_data/ensemble_plot_gen_kw_vector.py 57.14% <0.00%> (-4.77%) ⬇️
ert_shared/models/base_run_model.py 81.81% <0.00%> (-3.17%) ⬇️
libres/lib/enkf/enkf_plot_gendata.cpp 19.65% <0.00%> (-3.12%) ⬇️
ert_shared/status/tracker/evaluator.py 75.43% <0.00%> (-2.64%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab7882...40d09e0. Read the comment docs.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small comment!

Copy link
Contributor

@markusdregi markusdregi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the removed test equals the parameterisation now included. Change the name and then I think this is good to go 🚀

@oyvindeide oyvindeide merged commit f14012d into equinor:main Feb 18, 2022
@oyvindeide oyvindeide deleted the parameterize_test branch February 18, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants