-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize test instead of having duplicate #2810
Conversation
31901ba
to
fe7c511
Compare
Codecov Report
@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
- Coverage 65.23% 65.20% -0.04%
==========================================
Files 651 653 +2
Lines 53549 53496 -53
Branches 4784 4790 +6
==========================================
- Hits 34935 34883 -52
+ Misses 17041 17011 -30
- Partials 1573 1602 +29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the removed test equals the parameterisation now included. Change the name and then I think this is good to go 🚀
fe7c511
to
40d09e0
Compare
40d09e0
to
fd6345e
Compare
Issue
Some cleaning up of tests.
Pre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml