Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup redundant parameters #2853

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

sregales-TNO
Copy link
Contributor

Approach
Remove and replace redundant parameters.

@sregales-TNO sregales-TNO added enhancement maintenance Not a bug now but could be one day, repaying technical debt labels Feb 7, 2022
@sregales-TNO sregales-TNO self-assigned this Feb 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #2853 (2a7cb88) into main (8195a4b) will increase coverage by 0.06%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2853      +/-   ##
==========================================
+ Coverage   65.12%   65.18%   +0.06%     
==========================================
  Files         654      653       -1     
  Lines       53515    53375     -140     
  Branches     4804     4800       -4     
==========================================
- Hits        34851    34794      -57     
+ Misses      17065    16983      -82     
+ Partials     1599     1598       -1     
Impacted Files Coverage Δ
libres/lib/analysis/update.cpp 40.25% <0.00%> (ø)
libres/lib/enkf/enkf_main.cpp 52.67% <100.00%> (-0.11%) ⬇️
libres/lib/enkf/ert_test_context.cpp 90.10% <100.00%> (-0.11%) ⬇️
res/enkf/enkf_main.py 83.92% <100.00%> (ø)
libres/lib/enkf/enkf_node.cpp 52.16% <0.00%> (-0.26%) ⬇️
res/config/__init__.py 100.00% <0.00%> (ø)
res/config/config_settings.py
ert_gui/gert_main.py 96.05% <0.00%> (+0.05%) ⬆️
libres/lib/res_util/block_fs.cpp 54.11% <0.00%> (+0.29%) ⬆️
ert_gui/ertwidgets/__init__.py 77.27% <0.00%> (+2.27%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8195a4b...2a7cb88. Read the comment docs.

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sregales-TNO sregales-TNO merged commit cfd7beb into equinor:main Feb 8, 2022
@sregales-TNO sregales-TNO deleted the feature/refactor_enkf_main branch February 8, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants