Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #2910

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Remove unused function #2910

merged 1 commit into from
Feb 18, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Feb 15, 2022

Issue
Came across an unused function.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@oyvindeide
Copy link
Collaborator Author

test ert please

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #2910 (e948dce) into main (62af4ed) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
+ Coverage   65.08%   65.10%   +0.01%     
==========================================
  Files         649      649              
  Lines       52610    52594      -16     
  Branches     4740     4730      -10     
==========================================
  Hits        34239    34239              
+ Misses      16828    16814      -14     
+ Partials     1543     1541       -2     
Impacted Files Coverage Δ
libres/lib/enkf/enkf_util.cpp 86.66% <ø> (+30.14%) ⬆️
ert3/console/_errors.py 85.71% <0.00%> (-14.29%) ⬇️
ert3/console/_console.py 87.50% <0.00%> (-0.80%) ⬇️
ert_gui/simulation/run_dialog.py 75.70% <0.00%> (-0.71%) ⬇️
ert3/engine/_run.py 93.20% <0.00%> (ø)
ert/exceptions/__init__.py 100.00% <0.00%> (ø)
ert/exceptions/_exceptions.py 100.00% <0.00%> (ø)
res/enkf/enums/active_mode_enum.py 100.00% <0.00%> (ø)
libres/lib/enkf/enkf_obs.cpp 66.91% <0.00%> (+0.24%) ⬆️
libres/lib/res_util/matrix.cpp 65.35% <0.00%> (+0.27%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62af4ed...e948dce. Read the comment docs.

Copy link
Contributor

@jondequinor jondequinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is unused, let's nuke it.

@oyvindeide oyvindeide merged commit cda4544 into equinor:main Feb 18, 2022
@oyvindeide oyvindeide deleted the remove_unused branch February 18, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants