Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from test_analysis_module #2919

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Feb 16, 2022

Re-write to not depend on ResTest.

Issue
Resolves #2918

Pre review checklist

  • [x ] Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@dafeda dafeda added the maintenance Not a bug now but could be one day, repaying technical debt label Feb 16, 2022
@dafeda
Copy link
Contributor Author

dafeda commented Feb 17, 2022

test this please

2 similar comments
@dafeda
Copy link
Contributor Author

dafeda commented Feb 17, 2022

test this please

@dafeda
Copy link
Contributor Author

dafeda commented Feb 18, 2022

test this please

@codecov-commenter
Copy link

Codecov Report

Merging #2919 (757ca7a) into main (f14012d) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
+ Coverage   65.16%   65.40%   +0.23%     
==========================================
  Files         650      648       -2     
  Lines       52625    52391     -234     
  Branches     4711     4674      -37     
==========================================
- Hits        34294    34264      -30     
+ Misses      16786    16580     -206     
- Partials     1545     1547       +2     
Impacted Files Coverage Δ
ert_gui/ertwidgets/validationsupport.py 79.45% <0.00%> (-19.18%) ⬇️
ert_gui/ertwidgets/__init__.py 75.00% <0.00%> (-2.28%) ⬇️
libres/lib/enkf/enkf_main_ensemble.cpp 68.42% <0.00%> (-0.81%) ⬇️
libres/lib/res_util/block_fs.cpp 53.67% <0.00%> (-0.30%) ⬇️
libres/lib/enkf/data_ranking.cpp
libres/lib/enkf/ranking_table.cpp
ert_shared/status/tracker/legacy.py 87.83% <0.00%> (+1.58%) ⬆️
libres/lib/enkf/enkf_main.cpp 57.84% <0.00%> (+4.04%) ⬆️
libres/lib/enkf/enkf_main_jobs.cpp 19.57% <0.00%> (+4.29%) ⬆️
libres/lib/enkf/enkf_util.cpp 86.66% <0.00%> (+30.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14012d...757ca7a. Read the comment docs.

@dafeda
Copy link
Contributor Author

dafeda commented Feb 21, 2022

test libres please

2 similar comments
@dafeda
Copy link
Contributor Author

dafeda commented Feb 21, 2022

test libres please

@dafeda
Copy link
Contributor Author

dafeda commented Feb 21, 2022

test libres please

Re-write to not depend on ResTest.
@dafeda dafeda self-assigned this Feb 21, 2022
@dafeda dafeda merged commit d2b47a7 into equinor:main Feb 21, 2022
@dafeda dafeda deleted the test_analysis_module branch February 21, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify test_analysis_module.py
3 participants