Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job_dispatch: Makedir in, out, err locations #2998

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Feb 28, 2022

No description provided.

@pinkwah pinkwah self-assigned this Feb 28, 2022
@pinkwah pinkwah changed the title job_dispatch: Make in, out, err files optional job_dispatch: Makedir in, out, err locations Feb 28, 2022
@oyvindeide
Copy link
Collaborator

Is it possible to add a failing test to this?

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #2998 (41d8494) into main (ea7cd5a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2998   +/-   ##
=======================================
  Coverage   65.69%   65.69%           
=======================================
  Files         640      640           
  Lines       51133    51133           
  Branches     4444     4444           
=======================================
+ Hits        33591    33592    +1     
+ Misses      16056    16054    -2     
- Partials     1486     1487    +1     
Impacted Files Coverage Δ
libres/lib/res_util/block_fs.cpp 53.67% <0.00%> (-0.15%) ⬇️
ert_gui/simulation/run_dialog.py 76.40% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7cd5a...41d8494. Read the comment docs.

@pinkwah
Copy link
Contributor Author

pinkwah commented Feb 28, 2022

Is it possible to add a failing test to this?

Done

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinkwah pinkwah merged commit c86ff93 into equinor:main Mar 1, 2022
@pinkwah pinkwah deleted the job branch October 24, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants