Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eigen in enkf_linalg #3035

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Use Eigen in enkf_linalg #3035

merged 2 commits into from
Mar 8, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Mar 7, 2022

Issue
Resolves #3040

Pre review checklist

  • [ x] Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@dafeda dafeda added the maintenance Not a bug now but could be one day, repaying technical debt label Mar 7, 2022
@dafeda dafeda self-assigned this Mar 7, 2022
@dafeda dafeda changed the title Matrix dgesvd Remove matrix_dgesvd Mar 7, 2022
@dafeda dafeda force-pushed the matrix_dgesvd branch 4 times, most recently from b098302 to 97155bd Compare March 7, 2022 14:23
@dafeda dafeda requested a review from pinkwah March 7, 2022 14:24
libres/lib/analysis/enkf_linalg.cpp Outdated Show resolved Hide resolved
libres/lib/analysis/enkf_linalg.cpp Outdated Show resolved Hide resolved
libres/lib/analysis/enkf_linalg.cpp Outdated Show resolved Hide resolved
libres/lib/analysis/enkf_linalg.cpp Outdated Show resolved Hide resolved
libres/lib/analysis/enkf_linalg.cpp Outdated Show resolved Hide resolved
libres/lib/analysis/ies/ies.cpp Outdated Show resolved Hide resolved
libres/tests/analysis/test_update.cpp Outdated Show resolved Hide resolved
@dafeda dafeda force-pushed the matrix_dgesvd branch 2 times, most recently from 0e80782 to 429f481 Compare March 7, 2022 18:54
@dafeda dafeda changed the title Remove matrix_dgesvd Use Eigen in enkf_linalg Mar 7, 2022
@dafeda dafeda force-pushed the matrix_dgesvd branch 2 times, most recently from 9776f46 to 0e7cc42 Compare March 8, 2022 07:24
Remove matrix_dgesvd
Use Eigen in enkf_linalg_svd
Remove unused dgesvd_get_vector_job
Co-authored-by: Zohar Malamant ZOM@equinor.com
@dafeda dafeda merged commit fee084c into equinor:main Mar 8, 2022
@dafeda dafeda deleted the matrix_dgesvd branch March 8, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Eigen in enkf_linalg
2 participants