Make port range larger in test #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortalisk
force-pushed
the
enlarge_port_range
branch
from
b2d3882
to
93a0474
Compare
xjules
reviewed
Mar 8, 2022
| @@ -50,8 +50,9 @@ def _run( | |||
|
|
|||
| def evaluate( | |||
| ensemble: Ensemble, | |||
| custom_port_range: Optional[range] = None, | |||
There was a problem hiding this comment.
Are we to expose port_range as parameter here? It smells a bit, what do you think @jondequinor ?
There was a problem hiding this comment.
I dunno. Any reason why not?
There was a problem hiding this comment.
You might be right though as I can't see any other way to deliver the port range there.
There was a problem hiding this comment.
I agree with both of you.
mortalisk
force-pushed
the
enlarge_port_range
branch
from
93a0474
to
762f2b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #3059 +/- ##
=======================================
Coverage 65.47% 65.48%
=======================================
Files 641 641
Lines 50631 50631
Branches 4440 4440
=======================================
+ Hits 33151 33155 +4
+ Misses 15986 15984 -2
+ Partials 1494 1492 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was not working when many workers running, as no ports were available.
https://ci.equinor.com/scout/job/komodo_testing/job/ert-custom-script-pr/9340/console