Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement mypy < 0.920 #3090

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove requirement mypy < 0.920 #3090

merged 1 commit into from
Mar 15, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Mar 15, 2022

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • [ x] Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dafeda dafeda force-pushed the bump_mypy branch 2 times, most recently from f19afee to 65801eb Compare March 15, 2022 09:16
@codecov-commenter
Copy link

Codecov Report

Merging #3090 (f19afee) into main (daf7551) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head f19afee differs from pull request most recent head 65801eb. Consider uploading reports for the commit 65801eb to get more accurate results

@@           Coverage Diff           @@
##             main    #3090   +/-   ##
=======================================
  Coverage   65.41%   65.41%           
=======================================
  Files         651      651           
  Lines       50791    50794    +3     
  Branches     4477     4477           
=======================================
+ Hits        33223    33227    +4     
  Misses      16059    16059           
+ Partials     1509     1508    -1     
Impacted Files Coverage Δ
ert3/config/_config_plugin_registry.py 85.88% <66.66%> (-0.71%) ⬇️
libres/lib/res_util/block_fs.cpp 53.97% <0.00%> (+0.14%) ⬆️
ert/data/record/_transformation.py 88.72% <0.00%> (+0.49%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@dafeda
Copy link
Contributor Author

dafeda commented Mar 15, 2022

test this please

@dafeda dafeda closed this Mar 15, 2022
@dafeda dafeda reopened this Mar 15, 2022
@dafeda dafeda merged commit 28bd8dc into equinor:main Mar 15, 2022
@dafeda dafeda deleted the bump_mypy branch March 15, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants