Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo, successfull -> successful #3107

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Mar 16, 2022

Issue
Resolves a common typo, successfull should be successful (but successfully has two l's)

Approach
search and replace

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@berland berland added the maintenance Not a bug now but could be one day, repaying technical debt label Mar 16, 2022
@ertomatic
Copy link
Collaborator

Can one of the admins verify this patch?

@sondreso
Copy link
Collaborator

Jenkins add to whitelist

@berland berland enabled auto-merge (rebase) March 16, 2022 14:38
@codecov-commenter
Copy link

Codecov Report

Merging #3107 (53db27e) into main (f7d4a5b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
- Coverage   65.42%   65.42%   -0.01%     
==========================================
  Files         653      653              
  Lines       50831    50831              
  Branches     4475     4475              
==========================================
- Hits        33255    33254       -1     
- Misses      16063    16065       +2     
+ Partials     1513     1512       -1     
Impacted Files Coverage Δ
libres/lib/job_queue/workflow.cpp 85.00% <ø> (ø)
ert_shared/cli/workflow.py 68.75% <100.00%> (ø)
ert_shared/ensemble_evaluator/evaluator.py 95.97% <100.00%> (ø)
ert_gui/ertwidgets/__init__.py 75.00% <0.00%> (-2.28%) ⬇️
ert/data/record/_transformation.py 88.23% <0.00%> (-0.50%) ⬇️
ert_shared/ensemble_evaluator/config.py 95.18% <0.00%> (ø)
libres/lib/res_util/block_fs.cpp 53.67% <0.00%> (+0.14%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@berland berland merged commit 7d0254f into equinor:main Mar 16, 2022
@sondreso sondreso added release-notes:maintenance Automatically categorise as maintenance change in release notes and removed maintenance Not a bug now but could be one day, repaying technical debt labels Apr 4, 2022
@berland berland deleted the successfull_typo branch April 25, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants