Refactor RunDialog to depend less on RunModel #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
force-pushed
the
run_model_reb
branch
2 times, most recently
from
344c2ec
to
191d143
Compare
jondequinor
reviewed
Mar 24, 2022
xjules
changed the title
Yes, I did. Rebasing commits one by one did the trick 😄 |
xjules
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3108 +/- ##
=======================================
Coverage 65.29% 65.30%
=======================================
Files 612 612
Lines 49298 49304 +6
Branches 4445 4445
=======================================
+ Hits 32189 32196 +7
- Misses 15618 15619 +1
+ Partials 1491 1489 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jondequinor
reviewed
Mar 25, 2022
ert_shared/models/base_run_model.py
Outdated
| return True | ||
| return False | ||
|
|
||
| def create_mask_from_failed_realizations(self) -> BoolVector: |
There was a problem hiding this comment.
Suggested change
| def create_mask_from_failed_realizations(self) -> BoolVector: | |
| def _create_mask_from_failed_realizations(self) -> BoolVector: |
jondequinor
reviewed
Mar 25, 2022
ert_shared/models/base_run_model.py
Outdated
| inverted_mask[index] = initial[index] and not successful | ||
| return inverted_mask | ||
|
|
||
| def count_successful_realizations(self) -> int: |
There was a problem hiding this comment.
Suggested change
| def count_successful_realizations(self) -> int: | |
| def _count_successful_realizations(self) -> int: |
jondequinor
reviewed
Mar 25, 2022
| @@ -56,6 +64,7 @@ def __init__(self, ert: EnKFMain, queue_config: QueueConfig, phase_count: int = | |||
| self._last_run_iteration: int = -1 | |||
| self._ert = ert | |||
| self.facade = LibresFacade(ert) | |||
| self._simulation_arguments = simulation_arguments | |||
There was a problem hiding this comment.
Maybe check if members initial_realizations_mask completed_realizations_mask can now be made private?
jondequinor
approved these changes
Mar 25, 2022
|
Could you shorten the commit message to be < 50 characters 🙂 |
This include updating some of the attributes and functions to become private in RunModel and making simulation arguments implicit attribute to RunModel.
sondreso
added
the
release-notes:maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3024
Approach
RunDialogby migrating simulation running info intoBaseRunModel- [ ] Makethis might be affected by Experiment server #2132 so left it for nowEvaluatorTrackeras a proxy forBaseRunModelPre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml