Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tracker progress #3110

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Test tracker progress #3110

merged 1 commit into from
Mar 17, 2022

Conversation

Blunde1
Copy link
Contributor

@Blunde1 Blunde1 commented Mar 16, 2022

Issue
Resolves #3111
Resolves #3092 which was wrong, but correctly points out that a test for _progress() is needed in EvaluatorTracker

Approach
Modify test_tracking_progress() with the following:

PartialSnapshots allow realizations to progress, while iterating "iter" in
CloudEvents allows phases to progress. Such progress should happen
when events are yielded by the tracker. This combined progress is tested.

Pre review checklist

  • Added appropriate labels

Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml

@Blunde1 Blunde1 self-assigned this Mar 16, 2022
@ertomatic
Copy link
Collaborator

Can one of the admins verify this patch?

@sondreso
Copy link
Collaborator

Jenkins add to whitelist

@sondreso sondreso closed this Mar 17, 2022
@sondreso sondreso reopened this Mar 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #3110 (4d868ba) into main (7d0254f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   65.44%   65.43%   -0.02%     
==========================================
  Files         653      653              
  Lines       50831    50831              
  Branches     4475     4475              
==========================================
- Hits        33268    33259       -9     
- Misses      16050    16058       +8     
- Partials     1513     1514       +1     
Impacted Files Coverage Δ
ert_gui/ertwidgets/validationsupport.py 86.30% <0.00%> (-12.33%) ⬇️
libres/lib/res_util/block_fs.cpp 53.38% <0.00%> (-0.15%) ⬇️
ert/data/record/_transformation.py 88.72% <0.00%> (+0.49%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jondequinor
Copy link
Contributor

@Blunde1 what was the source of the original issue? Could you give some more detail?

@Blunde1
Copy link
Contributor Author

Blunde1 commented Mar 17, 2022

@Blunde1 what was the source of the original issue? Could you give some more detail?

@jondequinor can you specify what you mean by "source"?
See comments in old issue #3092 and new issue #3111, and updated initial comment here. This will hopefully clarify the progress of this PR.

@Blunde1 Blunde1 merged commit e4ec2b1 into equinor:main Mar 17, 2022
@Blunde1 Blunde1 deleted the cli-progress-test branch March 17, 2022 09:06
@jondequinor
Copy link
Contributor

@jondequinor can you specify what you mean by "source"?

You explained it well! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants