Remove thread_pool.cpp, arg_pack.cpp et al
#3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkwah
changed the title
thread_pool.cppthread_pool.cpp, arg_pack.cpp et al
pinkwah
force-pushed
the
tp
branch
4 times, most recently
from
9863cb4
to
14a81d8
Compare
|
This looks good to me, but hard to judge what the impact is, did you test performance before/after? |
This file provides the `res_yield` function, which reduced down to just a 1ms sleep call. Replace Linux-only `pthread_yield` with standardised `std::this_thread::yield` and use it instead of the sleep.
sondreso
added
the
release-notes:maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the final remnants of
thread_poolandarg_packRIP you will be missed 馃槩
Resolves: #2774
Resolves: #3106