Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing test to verify whether the actual jobs finished or not #3119

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

BjarneHerland
Copy link
Contributor

Let the "jobs" touch a file upon normal exit, use existence of this file as robust indication of whether jobs succeded or not.

@codecov-commenter
Copy link

Codecov Report

Merging #3119 (0f7926c) into main (2c0c38b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3119   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files         653      653           
  Lines       50802    50803    +1     
  Branches     4475     4475           
=======================================
+ Hits        33263    33265    +2     
+ Misses      16025    16024    -1     
  Partials     1514     1514           
Impacted Files Coverage Δ
ert/data/record/_transformation.py 88.23% <0.00%> (-0.50%) ⬇️
libres/lib/res_util/thread_pool.cpp 76.92% <0.00%> (+0.16%) ⬆️
ert_gui/simulation/run_dialog.py 77.03% <0.00%> (+0.70%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@lars-petter-hauge lars-petter-hauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@BjarneHerland BjarneHerland merged commit 82575f6 into equinor:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants