Refactor interactions between JobQueue and LegacyEnsemble. #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondequinor
previously approved these changes
Mar 23, 2022
There was a problem hiding this comment.
I think this is good for many reasons. Setting us up for #3124, making the code clearer and simpler.
Thanks!
jondequinor
dismissed
their stale review
didn't see the failing tests, will re-visit
|
jenkins test pytest please |
|
jenkins test this please |
BjarneHerland
force-pushed
the
refactor_legacy_ensemble
branch
2 times, most recently
from
815b1b8
to
3e5bd91
Compare
Avoids barrier, thread and event-loop in cancel() and simplifies loop in JobQueue. Cancellation is now triggered simply by setting the stopped-flag in JobQueue, causing the JobQueue-loop to exit by raising a CancelledError which is propagated back to the asyncio-eventloop and handled there.
BjarneHerland
force-pushed
the
refactor_legacy_ensemble
branch
from
3e5bd91
to
716e6aa
Compare
25 tasks
sondreso
added
the
release-notes:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
At least resolves #3023 and probably #2844, but also increases general stability.
Cancellation is now triggered simply by setting the stopped-flag in JobQueue, causing the JobQueue-loop to exit by raising a CancelledError which gets propagated back to the asyncio-eventloop and handled there.
Avoids barrier, thread and event-loop in cancel() and simplifies loop in JobQueue.