Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors in rmtree #3155

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

BjarneHerland
Copy link
Contributor

Resolves #3153

This fails sometimes due to the suspected/known race where block_fs removes lockfiles on GC, which may or may not run in parallel with rmtree.

This fails sometimes due to the suspected/known race where block_fs
removes lockfiles on GC, which may or may not run in parallel with
rmtree.
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #3155 (20b6476) into main (32b4350) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3155      +/-   ##
==========================================
- Coverage   65.75%   65.27%   -0.49%     
==========================================
  Files         651      612      -39     
  Lines       50635    49262    -1373     
  Branches     4445     4445              
==========================================
- Hits        33296    32155    -1141     
+ Misses      15847    15617     -230     
+ Partials     1492     1490       -2     
Impacted Files Coverage Δ
ert_gui/ertwidgets/searchbox.py 33.33% <0.00%> (-22.92%) ⬇️
...ed/ide/keywords/definitions/argument_definition.py 90.00% <0.00%> (-10.00%) ⬇️
libres/lib/analysis/ies/ies.cpp 60.11% <0.00%> (-5.55%) ⬇️
libres/lib/analysis/ies/ies_config.cpp 80.00% <0.00%> (-4.13%) ⬇️
.../ertwidgets/models/analysismodulevariablesmodel.py 56.81% <0.00%> (-0.63%) ⬇️
res/job_queue/queue.py 84.59% <0.00%> (-0.32%) ⬇️
ert_gui/gert_main.py 96.00% <0.00%> (-0.11%) ⬇️
ert_shared/ide/keywords/data/__init__.py 100.00% <0.00%> (ø)
ert_shared/ide/keywords/definitions/__init__.py 100.00% <0.00%> (ø)
libres/lib/include/ert/analysis/ies/ies_data.hpp 0.00% <0.00%> (ø)
... and 47 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BjarneHerland BjarneHerland merged commit 2cf18ed into equinor:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_key_def_structure gives FileNotFoundError
4 participants