Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Title Case In Ert Gui #3190

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Drop Title Case In Ert Gui #3190

merged 1 commit into from
Apr 1, 2022

Conversation

berland
Copy link
Contributor

@berland berland commented Apr 1, 2022

Title Case were inconsistently in use in various GUI elements. This commit
removes All Of Them, except Ensemble Reservoir Toolbox.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #3190 (42d1e42) into main (63fe884) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3190      +/-   ##
==========================================
- Coverage   65.53%   65.52%   -0.02%     
==========================================
  Files         610      610              
  Lines       48975    48975              
  Branches     4403     4403              
==========================================
- Hits        32095    32089       -6     
- Misses      15413    15415       +2     
- Partials     1467     1471       +4     
Impacted Files Coverage Δ
ert_gui/ertwidgets/caselist.py 24.00% <0.00%> (ø)
.../ertwidgets/models/analysismodulevariablesmodel.py 56.81% <ø> (ø)
ert_gui/gert_main.py 96.00% <ø> (ø)
..._gui/tools/manage_cases/case_init_configuration.py 14.18% <0.00%> (ø)
ert_gui/tools/manage_cases/manage_cases_tool.py 76.92% <0.00%> (ø)
...tools/plot/customize/default_customization_view.py 30.23% <0.00%> (ø)
.../tools/plot/customize/limits_customization_view.py 24.32% <0.00%> (ø)
...ls/plot/customize/statistics_customization_view.py 20.68% <ø> (ø)
...i/tools/plot/customize/style_customization_view.py 30.76% <0.00%> (ø)
ert_gui/tools/plot/filter_popup.py 23.07% <0.00%> (ø)
... and 24 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@berland berland self-assigned this Apr 1, 2022
Title Case were inconsistently in use in various GUI elements. This commit
removes All Of Them, except Ensemble Reservoir Toolbox
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is the foundation of virtue.

- Francis Bacon

@berland berland merged commit 812aeef into equinor:main Apr 1, 2022
@sondreso sondreso added the release-notes:improvement Automatically categorise as improvement in release notes label Apr 4, 2022
@berland berland deleted the drop_title_case branch April 25, 2022 12:37
@berland berland mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants