Change default inversion to IES_INVERSION_EXACT #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeda
force-pushed
the
exact_inversion
branch
2 times, most recently
from
e27166a
to
07faa5e
Compare
dafeda
added
maintenance
As long as we are using diagonal observation error matrices R, we should use exact inversion because it does not entail truncation of the eigenvalue spectrum, and is faster.
Codecov Report
@@ Coverage Diff @@
## main #3193 +/- ##
==========================================
+ Coverage 65.53% 65.58% +0.05%
==========================================
Files 610 610
Lines 48891 48893 +2
Branches 4392 4392
==========================================
+ Hits 32041 32068 +27
+ Misses 15384 15354 -30
- Partials 1466 1471 +5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ManInFez
approved these changes
Apr 5, 2022
oyvindeide
added
the
release-notes:breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as we are using diagonal observation error matrices R,
we should use exact inversion because it does not entail truncation
of the eigenvalue spectrum, and is faster.
Issue
Resolves #3195
Pre review checklist
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml