Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintenance as release notes category #3199

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

sondreso
Copy link
Collaborator

@sondreso sondreso commented Apr 4, 2022

Issue
Maintenance is an often used category, and many PRs currently does not fit well in other categories.

Approach
Add maintenance as category

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@sondreso sondreso added the release-notes:misc Automatically categorise as miscellaneous change in release notes label Apr 4, 2022
@sondreso sondreso self-assigned this Apr 4, 2022
@sondreso sondreso requested a review from dafeda April 4, 2022 10:10
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sondreso sondreso enabled auto-merge (rebase) April 4, 2022 10:17
@codecov-commenter
Copy link

Codecov Report

Merging #3199 (73e37ae) into main (8248b97) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3199   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files         610      610           
  Lines       48891    48891           
  Branches     4392     4392           
=======================================
+ Hits        32041    32043    +2     
+ Misses      15384    15383    -1     
+ Partials     1466     1465    -1     
Impacted Files Coverage Δ
libres/lib/enkf/block_fs_driver.cpp 81.25% <0.00%> (-0.57%) ⬇️
libres/lib/res_util/block_fs.cpp 53.02% <0.00%> (+0.33%) ⬆️
ert/data/record/_transformation.py 88.72% <0.00%> (+0.49%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sondreso sondreso merged commit c5e6ab0 into equinor:main Apr 4, 2022
@sondreso sondreso deleted the maintenance-release-notes branch April 4, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants