Extend flake8 linting to ert-directory and ert_tests #3203
Conversation
berland
added
the
release-notes:maintenance
Codecov Report
@@ Coverage Diff @@
## main #3203 +/- ##
=======================================
Coverage 65.60% 65.61%
=======================================
Files 614 614
Lines 48977 48983 +6
Branches 4407 4407
=======================================
+ Hits 32133 32138 +5
Misses 15374 15374
- Partials 1470 1471 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
berland
force-pushed
the
flake_ert
branch
2 times, most recently
from
cf1178a
to
15e7d19
Compare
| f"\nexperiment_json: {json.dumps(experiment_json, indent=1)} \n\n" | ||
| f"ensemble_json: {json.dumps(ensemble_json, indent=1)}\n" | ||
| f" status_code: {resp.status_code}" | ||
| ) |
There was a problem hiding this comment.
Out of curiosity - why do you have brackets () here? Why not just split the line using backslash?
There was a problem hiding this comment.
also, imports in this file can be optimised - pylint picks up that pytest is not used and the order is
import io
import json
import uuid
import pandas as pd
from numpy.testing import assert_array_equal
from requests import Response
P.S. Sorry for putting the comment here, could not figure out how to attach it to imports when you haven't made changes there ..
There was a problem hiding this comment.
Actually, we do not do pylint on tests, and this PR is about flake8, so I retrieve my comment about imports :)
There was a problem hiding this comment.
I chose round-bracket-string-concatenation because I found it a tad more readable here. But that might be a matter of taste.
Sorted imports (isort) and removed the superfluous import in this file. Bonus change..
There was a problem hiding this comment.
Yes, I already googled that brackets is a preferred way to split the line and not backslash
Issue
Resolves missing flake8 requirements for parts of the codebase
Approach
Add flake8 testing in Github Actions runner to include more directories, and fix related flake8 issues
in those directories.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.