dlopen libres with RTLD_LOCAL #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkwah
force-pushed
the
pinkwah-patch-1
branch
4 times, most recently
from
6d7b284
to
49b85e1
Compare
Closed
BjarneHerland
added a commit
to BjarneHerland/ert
that referenced
this pull request
Apr 13, 2022
Fixed some unit-tests and allow loading from main-process as fallback Using RTLD_GLOBAL adds all of the symbols within libres into the global symbol table of the running process. This can interfere with other libraries that rely on the same dependencies that we do (eg. pybind11) but use a different version. The symbols conflict and you might get a segmentation fault or worse.
BjarneHerland
added a commit
to BjarneHerland/ert
that referenced
this pull request
Apr 13, 2022
Fixed some unit-tests and allow loading from main-process as fallback Using RTLD_GLOBAL adds all of the symbols within libres into the global symbol table of the running process. This can interfere with other libraries that rely on the same dependencies that we do (eg. pybind11) but use a different version. The symbols conflict and you might get a segmentation fault or worse.
pinkwah
force-pushed
the
pinkwah-patch-1
branch
3 times, most recently
from
8835fd4
to
4faa6e9
Compare
Using RTLD_GLOBAL adds all of the symbols within libres into the global symbol table of the running process. This can interfere with other libraries that rely on the same dependencies that we do (eg. pybind11) but use a different version. The symbols conflict and you might get a segmentation fault or worse.
pinkwah
force-pushed
the
pinkwah-patch-1
branch
from
4faa6e9
to
f10e8f3
Compare
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
| workflow_job->module, dlerror()); | ||
|
|
||
| if (!workflow_job->lib_handle) { | ||
| fprintf(stderr, "Failed to load symbol:%s Error:%s \n", |
There was a problem hiding this comment.
Perhaps "Failed to load module" since that is what failed?
sondreso
added
the
release-notes:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using RTLD_GLOBAL adds all of the symbols within libres into the global symbol table of the running process. This can interfere with other libraries that rely on the same dependencies that we do (eg. pybind11) but use a different version. The symbols conflict and you might get a segmentation fault or worse.